MediaWiki talk:Gadget-ListingEditor2023.js Voyage Tips and guide

Contents

In order to minimize similar issues, please inform me before deploying a patch so I can test it in advance. Thanks, Andyrom75 (talk) 15:53, 18 July 2024 (UTC)Reply

Hey there I just had to disable the gadget with my staff hat on because it was logging an error for every page view.

Back with my volunteer hat on, I haven't updated the gadget in about 2 weeks and even then most of those changes have not been major. Is it possible you are hitting issues with the heading roll out issue on https://www.mediawiki.org/wiki/Heading_HTML_changes . This makes me think it's setup incorrectly.

Looks like you are loading the gadget incorrectly using action=raw rather than load.php in https://it.wikivoyage.org/wiki/MediaWiki:Gadget-ListingEditor2023.js

Untested but switching

importScriptURI('https://en.wikivoyage.org/w/index.php?title=MediaWiki:Gadget-ListingEditor2023.js&action=raw&ctype=text/javascript');

with

importScriptURI('https://en.wikivoyage.org/w/load.php?modules=ext.gadget.ListingEditor2023');

might fix it! Jdlrobson (talk) 18:41, 18 July 2024 (UTC)Reply

@Jdlrobson, I don't know exactly when the problem occurs, I've just been alerted yesterday by a user.

I've just substitute in it:MediaWiki:Gadget-ListingEditor2023.js the line you wrote initially with the one you suggested.

I'll wait for some minutes to be sure that the cache won't affect the result of the test, then I'll try to rollback the most recent changes on Listing Editor script to verify if the problem is in this script or elsewhere. Andyrom75 (talk) 05:35, 19 July 2024 (UTC)Reply

@Jdlrobson, now it works, thanks. I've restored the default parameter on the "alpha" version.

Could you please support to implement also the "beta" version on it:voy? I've done some tentatives, but I didn't succeed. Andyrom75 (talk) 10:19, 19 July 2024 (UTC)Reply

Apparently I've implemented it, but in a different way it has been done here on en:voy, could you check if it's equivalent or if there's any mistake? Andyrom75 (talk) 14:50, 22 July 2024 (UTC)Reply

@Jdlrobson, I've just noticed that Listing Editor doesn't accept anymore all the various coordinates formats (e.g. 39°22′32″N). Could you check and restore the original function or eliminate the control that prevent to proceed? Thanks, Andyrom75 (talk) 06:37, 16 October 2024 (UTC)Reply

@Jdlrobson, @Jon (WMF), please confirm the receipt of the message. Andyrom75 (talk) 07:13, 24 October 2024 (UTC)Reply

Https://github.com/jdlrobson/Gadget-Workshop/issues/4

@Jdlrobson, there's a problem with the listing "Bastione Conca" present in Trapani. Clicking on "Sync shared fields to/from Wikidata", doesn't appear any popup, neither the one to change the parameter, nor the one that state that all is aligned.

The only difference I see with other Wikidata instance, is the absence of coordinates in Wikidata. Please check it and let me know. Andyrom75 (talk) 18:27, 21 July 2024 (UTC)Reply

I think this is the same issue tracked in https://github.com/jdlrobson/Gadget-Workshop/issues/4 - I haven't been able to look at that feature yet. The code is pretty complicated so I haven't managed to reverse-engineer it. Jdlrobson (talk) 21:36, 21 July 2024 (UTC)Reply

@Jdlrobson, look at it:Trapani#Castello di Terra (Item 13). It works correctly.

I've cloned it twice:

• Item 15: the same but with the image of Item 14 ("Bastione Conca")
• Item 16: identical to Item 13.

All the three items use the same Wikidata instance.

Item 16 works correctly as Item 13, while Item 15 has the same issue of "Bastione Conca".

Could you check if the problem is on the parsing logic? Andyrom75 (talk) 14:47, 22 July 2024 (UTC)Reply

I hope you'll have soon some spare time to give a look at it. In the meanwhile, I remove the 2 "test listing" I've inserted to show you the issue.

Just to avoid that I'll forget to clean the article in the future :-) Andyrom75 (talk) 12:20, 25 July 2024 (UTC)Reply

@Jdlrobson, sorry, I forgot the ping :-) Andyrom75 (talk) 21:23, 25 July 2024 (UTC)Reply

@Jdlrobson, @Jon (WMF), I'm sure you are pretty busy with other WMF institutional tasks, so I don't want to bother you with the resolution of the existing bugs of the new listing editor version, but I would ask you to restore in the meanwhile the previous version because, although it's slow, it works perfectly. Once done we can restore the new version. Thanks in advance for your understanding and support, Andyrom75 (talk) 17:36, 8 December 2024 (UTC)Reply

Which bugs @Andyrom75? Could you please be specific?

There is only two I am aware of at https://github.com/jdlrobson/Gadget-Workshop/issues and that doesnt seem high priority? Please make sure the dialog says 3.6.0 or higher to confirm you are using the latest code. The coordinates issue I just looked into today, I had assumed it was low priority and not disrupting workflows (FWIW it doesnt seem like it was ever working that way?).

There have been fixes in the beta for all the issues you raised since Nov 5th. I promoted this just noBoldw. Generally I am not sure how you want to use beta going forward - nobody is telling me when to promote code so I am not sure what the process should be and I'd rather drop it to be honest as it seems to be complicating this workflow. I certainly wouldnt recommend adding a beta to itwikivoyage per your earlier request.

I am not exactly sure what you mean by old version. Given the changes to Parsoid a lot of the older versions have even more serious issues.

On a general note please do make sure bugs are represented on that issue page not on talk pages. I juggle many things and unless there are issue tickets I will miss them. Apologies if I have missed a specific bug that is causing you lots of problems. Will be happy to look into it once you have established the exact problem. Jdlrobson (talk) 18:49, 8 December 2024 (UTC)Reply

@Jdlrobson, currently I'm experiencing three kind of bugs on it:voy (my home wiki, where I'm mostly active):

1. in certain cases (not better specified), the listing editor is not shown, because of a JS error on an "index"
2. coordinates were managed in both formats (not only decimal), while now, all the listings that use not decimal format, cannot be saved through the listing editor
3. Wikidata sync doesn't work

If one or more of the above bugs were already solve, I beg your pardon, I wasn't aware of it. Just let me know and I'll be glad to test it/them. Thanks, Andyrom75 (talk) 19:33, 8 December 2024 (UTC)Reply

@Jdlrobson, I've just tested in it:Sant'Antioco (Italia)#Catacombe di Sant'Antioco.

Opening the LE and then the Wikidata sync page, I've noticed that "Auto" link doesn't work, however, if I force the preference on one it:voy value, I've been able to save it into Wikidata.

The coordinate issue remains, in fact, I'm not able to save the listing in it:voy. Andyrom75 (talk) 20:06, 8 December 2024 (UTC)Reply

@Jdlrobson, I've tested it:special:permalink/857029#Hotel Rusadir. I still get the error on index. If you want to try it personally, you have to revert the current page, into the old one (I don't know what provoke the error on the index). Andyrom75 (talk) 20:23, 8 December 2024 (UTC)Reply

Do any of these bugs exist for you when using English Wikivoyage? Jdlrobson (talk) 20:27, 8 December 2024 (UTC)Reply

@Jdlrobson it's difficult to find another occurrence for the JS index error. On it:voy it happend to me few minutes before writing you.

I'll check the others. Andyrom75 (talk) 20:31, 8 December 2024 (UTC)Reply

"Auto" link, doesn't work on en:voy as well, although now, also there, the Wikidata sync page can be opened.

Non-decimal coordinates are not anymore accepted on en:voy as well. Andyrom75 (talk) 20:36, 8 December 2024 (UTC)Reply

I just remembered another minor thing that stop working. The addition of the trailing period when missing.

This code took care of it:

if ( $('#input-content').val() ) {

$('#input-content').val(($.trim($('#input-content').val())+'.').replace(/([\.\!\?])\.+$/, '$1'));

} Andyrom75 (talk) 20:44, 8 December 2024 (UTC)Reply

I've replicated #1: https://github.com/jdlrobson/Gadget-Workshop/issues/11

I'll look into it later. This one's a new bug I haven't seen before. Should be easy to fix.

1. 2 is only fixed in the beta of English Wikivoyage. If you can confirm it's working to your satisfaction there I can promote it to the stable version so it works on Italian. Please check your version matches the one here: https://phabricator.wikimedia.org/F57789374
2. 3 I need more clearer replication instructions. Please explain the particular edit button you clicked on what revision and on what page where the auto link doesn't work and I'll create a bug and look into it.

Jdlrobson (talk) 20:40, 8 December 2024 (UTC)Reply

I'll check it just after dinner. Thanks for your time. Andyrom75 (talk) 20:45, 8 December 2024 (UTC)Reply

The normal behavior of "auto" link is to select automatically Wikidata or Wikivoyage in any line, where only one of the two values is filled. When both are present, nothing happen.

You can easily simulate it, adding "x" on any value not present in wikidata and only after press the link to open the wikidata sync page. At that point press "auto" and you'll see that nothing happens. Andyrom75 (talk) 21:13, 8 December 2024 (UTC)Reply

I've checked the the beta on it:voy. I've noticed that when saving, it convert the coordinated into decimal format, but the old behavior is to keep the original format. The only check is to verify that the format is acceptable and in the affirmative case, the coords should be saved as inserted by the user. Furthermore it saved a lot of decimals, while only 6 should be accepted. Andyrom75 (talk) 21:21, 8 December 2024 (UTC)Reply

@Jdlrobson, sorry, I forgot the ping... Andyrom75 (talk) 21:21, 8 December 2024 (UTC)Reply

1. So it looks like the issue with the editor not open is an issue with Parsoid. I filed phab:T381786 - there is nothing I can do with that. You can disable Parsoid in the mean time if it is disrupting workflow. The issue is due to the heading wikitext being on the same line as a comment (-->)

2. So it looks like what happened here is a bug fix for another issue reported by a user (not you) led to this. I documented on https://github.com/jdlrobson/Gadget-Workshop/issues/10 and will think about it som more. There was a bug request from another user on enwikivoyage (not you) to remove the trailing period. You need to update your project config with the following if you want that batter:

::::::::::::"APPEND_FULL_STOP_TO_DESCRIPTION": true
::::::::::::

3. I think I see what's happening here. I opened https://github.com/jdlrobson/Gadget-Workshop/issues/13

Any other issues, please submit them to Github as I'm not looking into them right now and I can't keep on top of requests from different talk pages.

Also no need to ping in future. I subscribe to all messages on this page. Jdlrobson (talk) 17:15, 9 December 2024 (UTC)Reply

• Thanks for the configuration of the full stop on content/descrizione parameter and for the fix on "Auto link" fix; both of them works.
• Ok for the bug on Phabricator. I'll pay attention to see if this is the only case that prevent LE to be opened.
• It seems that coordinates in DMS are not anymore accepted. In the short term it's better to keep your previous attempt: accept & convert into decimal (but limiting to 6 decimals). At least we would be able to save listing that use coords in DMS format. When you'll have time, you could just save the coords in DMS format as inserted by the user (no need to convert them, since the listing itself already accept DMS format)

Andyrom75 (talk) 22:24, 9 December 2024 (UTC)Reply

I've restored the acceptance of the DMS format, trimming the result at 6 decimal. Please check the code, that for sure can be optimized. I'll keep on testing it for a while. --Andyrom75 (talk) 10:05, 11 December 2024 (UTC)Reply

@Jdlrobson, I think it's fine and can be promoted. When you have some spare time, please fill Wikivoyage:Listing_editor#Changelog to track the improvement. Andyrom75 (talk) 09:15, 14 December 2024 (UTC)Reply

In the meanwhile I've promoted the beta and filled the Changelog for the v3.7.0. Please double check at your earliest convenience. Andyrom75 (talk) 11:43, 16 December 2024 (UTC)Reply

Thanks! Jdlrobson (talk) 01:34, 3 January 2025 (UTC)Reply

@Jdlrobson, it's not urgent, but if you have some spare time, please update Wikivoyage:Listing_editor#Changelog from "v3.0.0 Changes" up to "v3.6.0 Changes". This will help to find the code associated to a specific feature.

This is how I've found the DMS code in "v2.4" and applied in "v3.7.0". Andyrom75 (talk) 12:12, 18 January 2025 (UTC)Reply

@Jdlrobson, a part the log, I'd like to highlight you that on it:voy we have an issue. Every section has "[ modifica ]aggiungi elemento" instead of "[ modifica ][ aggiungi elemento ]". Could you check it? Andyrom75 (talk) 19:54, 14 March 2025 (UTC)Reply

@Jdlrobson, it took me a while but at the end I've found the problem. On February you apply this change; that's why on en:voy all works properly.

Please, if in the future you'll apply other changes, let me know or at least log them somewhere. Thanks, Andyrom75 (talk) 15:16, 23 March 2025 (UTC)Reply